Converts NavDrawer, NavDrawerGroup, and NavDrawerFlyout to TypeScript#3268
Converts NavDrawer, NavDrawerGroup, and NavDrawerFlyout to TypeScript#3268thompsongl merged 7 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
7883db6 to
4e97606
Compare
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3268/ |
thompsongl
left a comment
There was a problem hiding this comment.
Thank you, @dimitropoulos!
Nice work, as always, so I think this is close.
4e97606 to
d642d97
Compare
|
thanks for the swift review @thompsongl! I think it's pretty much ready to go now 🐎 |
thompsongl
left a comment
There was a problem hiding this comment.
Just a couple small things and the merge conflict to fix.
Confirmed that these changes work with very minor upates to Kibana
Co-Authored-By: Greg Thompson <thompson.glowe@gmail.com>
Co-Authored-By: Greg Thompson <thompson.glowe@gmail.com>
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3268/ |
thompsongl
left a comment
There was a problem hiding this comment.
LGTM!
Built locally and tested the output in Kibana (type check script and manual smoke test)
|
@dimitropoulos are you a GSoC applicant? |
@tushar22-tg Google Summer of Code? no, just a friendly neighborhood open source contributor :) |
Summary
closes #2658
closes #2772
I decided it would be most scientific (and interesting!) to do a clean-room implementation (at first, anyway) from the original PR #2772. Upon taking a look, a lot of the things are the same, but many are different.
As always, I tried very hard to stick to the components in question to avoid scope creep ("Rome wasn't built in a day"-kinda thing), as well as notating every single instance where I feel that there's potential for logical changes :)
Checklist
Checked in mobileChecked in IE11 and FirefoxAdded documentation examplesChecked for accessibility including keyboard-only and screenreader modes