Skip to content

fixed data grid sort popover #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snide merged 4 commits into from
Mar 4, 2020
Merged

fixed data grid sort popover #2979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
676dd95
fixed data grid sort popover
anishagg17 Mar 4, 2020
ff54e39
Update CHANGELOG.md
anishagg17 Mar 4, 2020
49e43ac
Update CHANGELOG.md
anishagg17 Mar 4, 2020
d0609cb
removed extra changes
anishagg17 Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `20.1.0`.
**Bug Fixes**

- Fixed `EuiDataGrid`'s sort popover to behave properly on mobile screens ([#2979](https://github.com/elastic/eui/pull/2979))

## [`20.1.0`](https://github.com/elastic/eui/tree/v20.1.0)

Expand Down
7 changes: 3 additions & 4 deletions src/components/datagrid/column_sorting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ export const useColumnSorting = (
<EuiFlexGroup
alignItems="center"
gutterSize="s"
component="span">
component="span"
responsive={false}>
<EuiFlexItem grow={false}>
<EuiToken
iconType={
Expand All @@ -251,9 +252,7 @@ export const useColumnSorting = (
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiText size="xs">
<span>{id}</span>
</EuiText>
<EuiText size="xs">{id}</EuiText>
</EuiFlexItem>
</EuiFlexGroup>
</button>
Expand Down