Skip to content

Fix EuiIconTip TS types #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandlerprall merged 2 commits into from
May 8, 2019
Merged

Fix EuiIconTip TS types #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fe3adb
Fix EuiIconTip TS types
chandlerprall May 8, 2019
f0cc8e5
changelog
chandlerprall May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `11.0.0`.
**Bug fixes**

- Fixed `EuiIconTip`'s typescript definition ([#1934](https://github.com/elastic/eui/pull/1934))

## [`11.0.0`](https://github.com/elastic/eui/tree/v11.0.0)

Expand Down
11 changes: 8 additions & 3 deletions src/components/tool_tip/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export { EuiToolTipPopover } from './tool_tip_popover';
import { ReactElement, ReactNode, FunctionComponent } from 'react';
import { EuiIcon } from '../icon';
import { EuiIcon, IconType } from '../icon';
import { Omit, PropsOf } from '../common';

declare module '@elastic/eui' {
Expand Down Expand Up @@ -28,10 +28,15 @@ declare module '@elastic/eui' {

export interface EuiIconTipProps {
color?: string;
type?: string;
type?: IconType;
size?: string;
'aria-label'?: string;
iconProps?: PropsOf<typeof EuiIcon>;

// EuiIconTip's `type` is passed to EuiIcon, so we want to exclude `type` from
// iconProps; however, due to TS's bivariant function arguments `type` could be
// passed without any error/feedback so we explicitly set it to `never` type
iconProps?: Omit<PropsOf<EuiIcon>, 'type'> & { type?: never };
}

export const EuiIconTip: FunctionComponent<Omit<EuiToolTipProps, 'children'> & EuiIconTipProps>;
}