Updated popover position to correctly address arrow buffer#1490
Merged
chandlerprall merged 3 commits intoelastic:masterfrom Jan 29, 2019
Merged
Conversation
nreese
approved these changes
Jan 29, 2019
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
Tested changes in Kibana and now the tooltip stays on the bottom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses a bug @nreese found in elastic/kibana#29235
The tooltip has a whitespace buffer of 16px, and its arrow must be 4px from its edge. Nathan's super update button is less than 16px from the right side of the screen; the calculations were shifting the popover to meet the buffer but didn't properly account for the 4px needed for the arrow, which forced the popover to an undesired position.
@nreese mind building the fix and confirming it works in your Kibana branch?
Checklist
- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components