Skip to content

Fix versioning for tests cases using a randomly generated rank builder #95514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdconrad merged 2 commits into from
Apr 24, 2023
Merged

Fix versioning for tests cases using a randomly generated rank builder #95514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
825bc45
Fix versioning for tests cases using a randomly generated rank builder.
jdconrad Apr 24, 2023
c6c0868
Update docs/changelog/95514.yaml
jdconrad Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/95514.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 95514
summary: Fix versioning for tests cases using a randomly generated rank builder
area: Ranking
type: bug
issues: []
6 changes: 6 additions & 0 deletions server/src/test/java/org/elasticsearch/search/internal/ShardSearchRequestTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,9 @@ public void testChannelVersion() throws Exception {
if (Optional.ofNullable(request.source()).map(SearchSourceBuilder::knnSearch).map(List::size).orElse(0) > 1) {
version = TransportVersionUtils.randomVersionBetween(random(), TransportVersion.V_8_7_0, TransportVersion.CURRENT);
}
if (request.source() != null && request.source().rankBuilder() != null) {
version = TransportVersionUtils.randomVersionBetween(random(), TransportVersion.V_8_8_0, TransportVersion.CURRENT);
}
request = copyWriteable(request, namedWriteableRegistry, ShardSearchRequest::new, version);
channelVersion = TransportVersion.min(channelVersion, version);
assertThat(request.getChannelVersion(), equalTo(channelVersion));
Expand All @@ -253,6 +256,9 @@ public void testWillCallRequestCacheKeyDifferentiators() throws IOException {

public void testForceSyntheticUnsupported() throws IOException {
SearchRequest request = createSearchRequest();
if (request.source() != null) {
request.source().rankBuilder(null);
}
request.setForceSyntheticSource(true);
ShardSearchRequest shardRequest = createShardSearchReqest(request);
StreamOutput out = new BytesStreamOutput();
Expand Down