Fix versioning for tests cases using a randomly generated rank builder#95514
Merged
jdconrad merged 2 commits intoelastic:mainfrom Apr 24, 2023
Merged
Fix versioning for tests cases using a randomly generated rank builder#95514jdconrad merged 2 commits intoelastic:mainfrom
jdconrad merged 2 commits intoelastic:mainfrom
Conversation
jdconrad
added
>bug
:Search Relevance/Ranking
Collaborator
|
Hi @jdconrad, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
Author
|
@rjernst Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain tests generate a random search request. These search requests aren't versioned, so in certain tests if a rank builder is set, the versions must be appropriately gated or the rank builder must be set to
null. This change fixes the issues fortestForceUnsupportedSyntheticandtestChannelVersion.