Remove compareAndSet in failure handling

[joegallo]

As requested in #92308 (comment) (which I'm finally getting back to, yikes!).

Instead of a compareAndSet followed by an accumulateAndGet, just use a single accumulateAndGet compareAndExchange for everything.

I'm 97.5% sure the logic of this remains correct, and I think it's simpler this way, but if somebody can point out a bug in the logic or disagrees about it being simpler, I'm happy to change or close this PR.

For a bit of the history on this, see https://github.com/elastic/elasticsearch/pull/23969 (code highlighting to avoid a github reference being added), as well as #37649 and #53262.

[elasticsearchmachine]

Pinging @elastic/es-core-infra (Team:Core/Infra)

[DaveCTurner]

This all seems very complicated compared with the approach in RefCountingListener. Either this can be simplified, or RefCountingListener has a bug...

elasticsearch/server/src/main/java/org/elasticsearch/action/support/RefCountingListener.java

Lines 215 to 218 in d875dc2

	final var firstException = exceptionRef.compareAndExchange(null, e);
	if (firstException != null && firstException != e) {
	firstException.addSuppressed(e);
	}

[joegallo]

I'm good with that solution. addSuppressed is already synchronized, so I think your approach would work fine. edit: Done, 5209fe7.

[DaveCTurner]

LGTM

[thecoop]

Looks sensible!