Replace failure.get().addSuppressed with failure.accumulateAndGet() #37649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test for concurrent incoming failures
javanna
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
Actually, failure.get().addSuppressed is fine as-is, as we keep on adding to the same exception (the exception in the reference never changes once set) and addSuppressed is synchronized. I may just merge the test and revert the change to GroupedActionListener. |
s1monw
approved these changes
Jan 21, 2019
|
retest this please |
|
run elasticsearch-ci/1 |
jasontedor
pushed a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 8, 2020
…lastic#37649) Also add a test for concurrent incoming failures
|
I backported this to 6.8 since I applied a bug fix on top of it in #53262. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace failure.get().addSuppressed with failure.accumulateAndGet() in GroupedActionListener, also add a test for concurrent incoming failures.