Avoid NPE in Stateless Get/mGet

docs/changelog/94164.yaml

@@ -0,0 +1,5 @@
+pr: 94164
+summary: Avoid NPE in Stateless Get/mGet
+area: CRUD
+type: bug
+issues: []

server/src/main/java/org/elasticsearch/action/get/TransportGetAction.java

@@ -71,23 +71,26 @@ protected boolean resolveIndex(GetRequest request) {
 
     @Override
     protected ShardIterator shards(ClusterState state, InternalRequest request) {
-        ShardIterator shards = clusterService.operationRouting()
+        ShardIterator iterator = clusterService.operationRouting()
             .getShards(
                 clusterService.state(),
                 request.concreteIndex(),
                 request.request().id(),
                 request.request().routing(),
                 request.request().preference()
             );
+        if (iterator == null) {
+            return null;
+        }
         // If it is stateless, only route isPromotableToPrimary shards. This is a temporary workaround until a more cohesive solution can be
         // implemented for search shards.
         if (DiscoveryNode.isStateless(clusterService.getSettings())) {
             return new PlainShardIterator(
-                shards.shardId(),
-                shards.getShardRoutings().stream().filter(ShardRouting::isPromotableToPrimary).collect(Collectors.toList())
+                iterator.shardId(),
+                iterator.getShardRoutings().stream().filter(ShardRouting::isPromotableToPrimary).collect(Collectors.toList())
             );
         } else {
-            return shards;
+            return iterator;
         }
     }
 

server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java

@@ -85,17 +85,20 @@ protected boolean resolveIndex(MultiGetShardRequest request) {
 
     @Override
     protected ShardIterator shards(ClusterState state, InternalRequest request) {
-        ShardIterator shards = clusterService.operationRouting()
+        ShardIterator iterator = clusterService.operationRouting()
             .getShards(state, request.request().index(), request.request().shardId(), request.request().preference());
+        if (iterator == null) {
+            return null;
+        }
         // If it is stateless, only route promotable shards. This is a temporary workaround until a more cohesive solution can be
         // implemented for search shards.
         if (DiscoveryNode.isStateless(clusterService.getSettings())) {
             return new PlainShardIterator(
-                shards.shardId(),
-                shards.getShardRoutings().stream().filter(ShardRouting::isPromotableToPrimary).collect(Collectors.toList())
+                iterator.shardId(),
+                iterator.getShardRoutings().stream().filter(ShardRouting::isPromotableToPrimary).collect(Collectors.toList())
             );
         } else {
-            return shards;
+            return iterator;
         }
     }