Skip to content

Comments

Avoid NPE in Stateless Get/mGet#94164

Merged
pxsalehi merged 2 commits intoelastic:mainfrom
pxsalehi:ps230227-avoidNPEInGet/mGet
Feb 28, 2023
Merged

Avoid NPE in Stateless Get/mGet#94164
pxsalehi merged 2 commits intoelastic:mainfrom
pxsalehi:ps230227-avoidNPEInGet/mGet

Conversation

@pxsalehi
Copy link
Member

In #93612 we introduce a
workaround for real-time get/mget for stateless. However there is a
null-check missing there (or maybe an assert).

@pxsalehi pxsalehi added >bug :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.7.1 v8.8.0 labels Feb 27, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Feb 27, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine
Copy link
Collaborator

Hi @pxsalehi, I've created a changelog YAML for you.

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxsalehi pxsalehi merged commit a1ef513 into elastic:main Feb 28, 2023
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.7 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 94164

pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Feb 28, 2023
In elastic#93612 we introduce
a workaround for real-time get/mget for stateless. However there
is a null-check missing there.
elasticsearchmachine pushed a commit that referenced this pull request Feb 28, 2023
In #93612 we introduce
a workaround for real-time get/mget for stateless. However there
is a null-check missing there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed Meta label for distributed team. v8.7.1 v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants