Convert full cluster restart tests to new rest testing framework #93422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d1240a2.
# Conflicts: # test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/AbstractLocalSpecBuilder.java # test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/DefaultLocalClusterSpecBuilder.java # test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/LocalClusterFactory.java # test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/LocalClusterSpec.java # test/test-clusters/src/main/java/org/elasticsearch/test/cluster/local/LocalSpecBuilder.java
`JvmErgonomics` requires various JVM options to be present, but if they are omitted then we throw a `NullPointerException` which looks to the user like an ES bug. They would have to be doing something a little odd to get into this state, but nonetheless it is possible to hit these NPEs. We don't need to handle such a config gracefully, but we should clarify why Elasticsearch won't start to help the user fix their config.
This commit changes the geoip downloader so that we only download the geoip databases if you have at least one geoip processor in your cluster, or when you add a new geoip processor (or if `ingest.geoip.downloader.eager.download` is explicitly set to true).
The issue with this test failure is actually that we were silently failing to install the plugin under test into the cluster. The root cause here was the FIPS security policy file was not copied into cluster config directory before we attempting to run the plugin installer. Since we pass the FIPS JVM arguments to all CLI tools as well this caused plugin installation to fail. We now ensure that these files are copied before we attempt to run _any_ ES tools. Closes elastic#93303
It's pretty common to run a block of code in a `try ... catch` block that just passes exceptions off to a listener's `onFailure` method. This commit adds a small utility to encapsulate this, enabling some one-liners.
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added
test-windows
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 1, 2023
…stic#93422) # Conflicts: # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MLModelDeploymentFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MlConfigIndexMappingsFullClusterRestartIT.java
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 1, 2023
…stic#93422) # Conflicts: # qa/full-cluster-restart/build.gradle # qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartIT.java # qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartSettingsUpgradeIT.java # qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/QueryBuilderBWCIT.java # x-pack/plugin/shutdown/qa/full-cluster-restart/build.gradle # x-pack/plugin/shutdown/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartIT.java # x-pack/qa/full-cluster-restart/build.gradle # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartSettingsUpgradeIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MLModelDeploymentFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MlConfigIndexMappingsFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MlHiddenIndicesFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/resources/system_key
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 2, 2023
#93422) (#93430) * Convert full cluster restart tests to new rest testing framework (#93422) # Conflicts: # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MLModelDeploymentFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MlConfigIndexMappingsFullClusterRestartIT.java * Fix test artifact * Fix build script --------- Co-authored-by: Elastic Machine <[email protected]>
This was referenced Feb 2, 2023
n1v0lg
added a commit
that referenced
this pull request
Feb 2, 2023
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 2, 2023
…ork (elastic#93422)" (elastic#93444) Reverts elastic#93422 Should address: elastic#93442 and possibly elastic#93440
This was referenced Feb 2, 2023
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 2, 2023
…g framework (elastic#93422)" (elastic#93444)" This reverts commit 221c935.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 2, 2023
…rk (#93422) (#93432) * Convert full cluster restart tests to new rest testing framework (#93422) # Conflicts: # qa/full-cluster-restart/build.gradle # qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartIT.java # qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/FullClusterRestartSettingsUpgradeIT.java # qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/upgrades/QueryBuilderBWCIT.java # x-pack/plugin/shutdown/qa/full-cluster-restart/build.gradle # x-pack/plugin/shutdown/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartIT.java # x-pack/qa/full-cluster-restart/build.gradle # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartSettingsUpgradeIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MLModelDeploymentFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MlConfigIndexMappingsFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/MlHiddenIndicesFullClusterRestartIT.java # x-pack/qa/full-cluster-restart/src/javaRestTest/resources/system_key * Fixes * Fix warning failures * Fix heap dump path * More fixes * Fix test cluster security setup on Windows * Use relative path for script execution * More, more fixes * Fix warning error * More fixes * Fix security warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93062 with some additional fixes.