Add ActionListener#run #93338
Add ActionListener#run #93338
Conversation
It's pretty common to run a block of code in a `try ... catch` block that just passes exceptions off to a listener's `onFailure` method. This commit adds a small utility to encapsulate this, enabling some one-liners.
DaveCTurner
added
>non-issue
:Distributed Indexing/Distributed
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| } catch (Exception e) { | ||
| listener.onFailure(e); | ||
| } | ||
| } |
There was a problem hiding this comment.
I wonder if that makes sense to have it non static?
public void completeWith(CheckedConsumer<ActionListener<T>, Exception> action) {
try {
action.accept(this);
} catch (Exception e) {
this.onFailure(e);
}
}
and usage:
listener.completeWith(it -> {
...
})
Though I am not sure if this is a better naming or actually simplifies the usage
There was a problem hiding this comment.
Yeah we could open that debate about most of these utilities. I'll stick with the common pattern for now tho.
|
Welp I think I broke the world here. I'm sure it's something obvious but I don't see what. I'll get back to this at some point. |
tlrx
left a comment
tlrx
left a comment
There was a problem hiding this comment.
I left a comment that could explain the test failures
| FileInfo fileInfo = fileInfos.get(); | ||
| if (fileInfo != null) { | ||
| fileSnapshotter.accept(context, fileInfo); | ||
| } |
There was a problem hiding this comment.
The listener must be completed here:
| } | |
| } | |
| l.onResponse(null) |
There was a problem hiding this comment.
Aha of course. ActionRunnable#run, the gift that keeps on giving.
It's pretty common to run a block of code in a `try ... catch` block that just passes exceptions off to a listener's `onFailure` method. This commit adds a small utility to encapsulate this, enabling some one-liners.
4 participants
It's pretty common to run a block of code in a
try ... catchblock that just passes exceptions off to a listener'sonFailuremethod. This commit adds a small utility to encapsulate this, enabling some one-liners.