Skip to content

Set forced_refresh to true when using stateless refresh work-around #93383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pxsalehi merged 1 commit into from
Jan 31, 2023
Merged

Set forced_refresh to true when using stateless refresh work-around #93383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,20 @@ public static <Response extends ReplicationResponse & WriteResponse> ActionListe

@Override
protected void doExecute(Task task, BulkRequest bulkRequest, ActionListener<BulkResponse> outerListener) {
// As a work-around to support `?refresh`, explicitly replace the refresh policy with a call to the Refresh API.
// As a work-around to support `?refresh`, explicitly replace the refresh policy with a call to the Refresh API,
// and always set forced_refresh to true.
// TODO: Replace with a less hacky approach.
ActionListener<BulkResponse> listener = outerListener;
if (DiscoveryNode.isStateless(clusterService.getSettings()) && bulkRequest.getRefreshPolicy() != WriteRequest.RefreshPolicy.NONE) {
listener = outerListener.delegateFailure((l, r) -> { client.admin().indices().prepareRefresh().execute(l.map(ignored -> r)); });
listener = outerListener.delegateFailure((l, r) -> client.admin().indices().prepareRefresh().execute(l.map(ignored -> {
for (BulkItemResponse response : r.getItems()) {
DocWriteResponse docWriteResponse = response.getResponse();
if (docWriteResponse != null) {
docWriteResponse.setForcedRefresh(true);
}
}
return r;
})));
bulkRequest.setRefreshPolicy(WriteRequest.RefreshPolicy.NONE);
}
/*
Expand Down