Set forced_refresh to true when using stateless refresh work-around #93383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>non-issue
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
Team:Distributed (Obsolete)
Member
Author
|
To be clear, I think this is just a missing piece from the first PR. At the time, I didn't know about it, and unfortunately there were no yaml tests to catch this. |
Member
I'm working on trying to enable some of them 😓 |
Member
Author
I know, I know! 😃 I just meant, that's why it slipped the tests back then! Also I thought it helps with your effort, and it's good to have as many enabled as possible. |
Member
Author
|
Thanks, Tanguy! |
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 31, 2023
…lastic#93383) In elastic#93160, we never set the forced_refresh flag in the response. With this change, the bulk response now correctly reflects what happened. It also unblocks a bunch of YAML tests for Stateless. Relates ES-5292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking what would it take to rework the temporary
?refreshsupport in #93160, I realized some YAML tests are failing because we never set theforced_refreshflag in the response. This is a simple fix and essentially is similar to what is happening in BulkShardResponse. I think with this, the bulk response now correctly reflects what happened. It also unblocks a bunch of YAML tests for Stateless. Those that explicitly check foris_false: forced_refresh, when usingWAIT_UNTIL, still fail.