Fix version error in cardinalit profile tests #77715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
I fixed an incorrect `skip` in the cardinality profiling tests yesterday. But! I fixed them incorrectly. Sadness. The new profiling was indeed added in 7.10, but an element of the profiling `post_collect` didn't exist until 7.12`. This updates the skip to be after 7.12 - we don't get any tests for the rest of the profiling, but those versions are pretty old now anyways. Closes elastic#77708, elastic#77709, elastic#77710
stu-elastic
approved these changes
Sep 14, 2021
Contributor
stu-elastic
left a comment
stu-elastic
left a comment
There was a problem hiding this comment.
That's a good lookin' skip, right thar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an incorrect
skipin the cardinality profiling testsyesterday. But! I fixed them incorrectly. Sadness. The new profiling was
indeed added in 7.10, but an element of the profiling
post_collectdidn't exist until 7.12`. This updates the skip to be after 7.12 - we
don't get any tests for the rest of the profiling, but those versions
are pretty old now anyways.
Closes #77708, #77709, #77710