Skip to content

Commit 7eb4615

Browse files
authored
Fix version error in cardinalit profile tests (#77715)
I fixed an incorrect `skip` in the cardinality profiling tests yesterday. But! I fixed them incorrectly. Sadness. The new profiling was indeed added in 7.10, but an element of the profiling `post_collect` didn't exist until 7.12`. This updates the skip to be after 7.12 - we don't get any tests for the rest of the profiling, but those versions are pretty old now anyways. Closes #77708, #77709, #77710
1 parent 71d2630 commit 7eb4615

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.aggregation/170_cardinality_metric.yml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,8 @@ setup:
216216
---
217217
"profiler int":
218218
- skip:
219-
# version: " - 7.9.99"
220-
# reason: new info added in 7.10.0
221-
version: "all"
222-
reason: "AwaitsFix https://github.com/elastic/elasticsearch/issues/77709"
219+
version: " - 7.11.99"
220+
reason: new info added in 7.10.0 but post_collection didn't exist in 7.11
223221
- do:
224222
search:
225223
body:
@@ -244,10 +242,8 @@ setup:
244242
---
245243
"profiler double":
246244
- skip:
247-
# version: " - 7.9.99"
248-
# reason: new info added in 7.10.0
249-
version: "all"
250-
reason: "AwaitsFix https://github.com/elastic/elasticsearch/issues/77710"
245+
version: " - 7.11.99"
246+
reason: new info added in 7.10.0 but post_collection didn't exist in 7.11
251247
- do:
252248
search:
253249
body:
@@ -272,10 +268,8 @@ setup:
272268
---
273269
"profiler string":
274270
- skip:
275-
# version: " - 7.9.99"
276-
# reason: new info added in 7.10.0
277-
version: "all"
278-
reason: "AwaitsFix https://github.com/elastic/elasticsearch/issues/77708"
271+
version: " - 7.11.99"
272+
reason: new info added in 7.10.0 but post_collection didn't exist in 7.11
279273
- do:
280274
search:
281275
body:

0 commit comments

Comments
 (0)