Fix permissions for UnboundID LDAP SDK #68872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We inadvertently removed permissions needed by the UnboundID LDAP SDK during a refactoring. This commit returns them to their rightful place. These permissions are needed in core because we force the class initializers for two classes from the UnboundID LDAP SDK to load while loading the x-pack-core plugin. We have to do this there because x-pack-core depends on the UnboundID LDAP SDK as some realm classes live in x-pack-core. Without these permissions, Elasticsearch will fail to start if an AD or LDAP realm is configured.
jasontedor
added
>bug
blocker
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Member
Author
|
@elasticmachine update branch |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tvernum
approved these changes
Feb 10, 2021
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
LGTM
I was able to start up a node with both SAML and LDAP configured, and authenticate with an LDAP user.
|
I don't see any mention of automated tests for this issue or LDAP auth. It is possible? Any plans for it? |
Contributor
|
I just repeated my test against master (without this fix) and it fails to start, as expected. |
Contributor
They're coming, but they'll take time. |
jasontedor
added a commit
that referenced
this pull request
Feb 10, 2021
We inadvertently removed permissions needed by the UnboundID LDAP SDK during a refactoring. This commit returns them to their rightful place. These permissions are needed in core because we force the class initializers for two classes from the UnboundID LDAP SDK to load while loading the x-pack-core plugin. We have to do this there because x-pack-core depends on the UnboundID LDAP SDK as some realm classes live in x-pack-core. Without these permissions, Elasticsearch will fail to start if an AD or LDAP realm is configured.
jasontedor
added a commit
that referenced
this pull request
Feb 10, 2021
We inadvertently removed permissions needed by the UnboundID LDAP SDK during a refactoring. This commit returns them to their rightful place. These permissions are needed in core because we force the class initializers for two classes from the UnboundID LDAP SDK to load while loading the x-pack-core plugin. We have to do this there because x-pack-core depends on the UnboundID LDAP SDK as some realm classes live in x-pack-core. Without these permissions, Elasticsearch will fail to start if an AD or LDAP realm is configured.
Hey, glad to see this has been raised. Is there any guide on how to fix, or will I need to wait for 7.11.1 release? |
Member
Author
|
Yes, there isn't a good workaround. We'll release 7.11.1 as fast as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We inadvertently removed permissions needed by the UnboundID LDAP SDK during a refactoring. This commit returns them to their rightful place.
These permissions are needed in core because we force the class initializers for two classes from the UnboundID LDAP SDK to load while loading the x-pack-core plugin. We have to do this there because x-pack-core depends on the UnboundID LDAP SDK as some realm classes live in x-pack-core.
Without these permissions, Elasticsearch will fail to start if an AD or LDAP realm is configured.
Relates #64743
Closes #68838