Change index removal reason when IndicesService is stopping#65876
Merged
tlrx merged 1 commit intoelastic:7.xfrom Dec 4, 2020
Merged
Change index removal reason when IndicesService is stopping#65876tlrx merged 1 commit intoelastic:7.xfrom
tlrx merged 1 commit intoelastic:7.xfrom
Conversation
…65816) When IndicesService is stopping on a data node, it closes every IndexService instances that are existing by calling the removeIndex(Index, IndexRemovalReason, String) method. The IndexRemovalReason that is passed as a parameter in this case is NO_LONGER_ASSIGNED which is also the one passed in other situation like removing an index because it got assigned to another data node. The fact that the same reason is used in multiple cases make it difficult for IndexEventListener to do the distinction between an index closed because the node is shutting down and an index closed between it moved away. This commit changes the IndexRemovalReason used when closing the IndicesService to be SHUTDOWN.
tlrx
added
>non-issue
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When IndicesService is stopping on a data node, it closes every
IndexService instances that are existing by calling the
removeIndex(Index, IndexRemovalReason, String) method.
The IndexRemovalReason that is passed as a parameter in this
case is NO_LONGER_ASSIGNED which is also the one passed
in other situation like removing an index because it got assigned
to another data node. The fact that the same reason is used in
multiple cases make it difficult for IndexEventListener to do the
distinction between an index closed because the node is
shutting down and an index closed between it moved away.
This commit changes the IndexRemovalReason used when
closing the IndicesService to be SHUTDOWN.
backport of #65816