Change index removal reason when IndicesService is stopping#65816
Merged
tlrx merged 3 commits intoelastic:masterfrom Dec 4, 2020
Merged
Change index removal reason when IndicesService is stopping#65816tlrx merged 3 commits intoelastic:masterfrom
tlrx merged 3 commits intoelastic:masterfrom
Conversation
tlrx
added
>non-issue
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Dec 3, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Hmm today CLOSED means POST /index/_close and friends, I don't think we should combine that with "shutting down". If we need the distinction, can we add a new value for the IndexRemovalReason enum instead?
Member
Author
|
Maybe |
Contributor
|
|
Member
Author
|
Thanks David, I updated the reason. |
DaveCTurner
approved these changes
Dec 4, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM.
I checked for, but did not find, places where we branch based on the index removal reason which would need updating too.
Member
Author
|
Thanks David. I checked too before opening the PR and did not found anything that would need to be adapted. |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
Dec 4, 2020
…65816) When IndicesService is stopping on a data node, it closes every IndexService instances that are existing by calling the removeIndex(Index, IndexRemovalReason, String) method. The IndexRemovalReason that is passed as a parameter in this case is NO_LONGER_ASSIGNED which is also the one passed in other situation like removing an index because it got assigned to another data node. The fact that the same reason is used in multiple cases make it difficult for IndexEventListener to do the distinction between an index closed because the node is shutting down and an index closed between it moved away. This commit changes the IndexRemovalReason used when closing the IndicesService to be SHUTDOWN.
tlrx
added a commit
that referenced
this pull request
Dec 4, 2020
…65876) When IndicesService is stopping on a data node, it closes every IndexService instances that are existing by calling the removeIndex(Index, IndexRemovalReason, String) method. The IndexRemovalReason that is passed as a parameter in this case is NO_LONGER_ASSIGNED which is also the one passed in other situation like removing an index because it got assigned to another data node. The fact that the same reason is used in multiple cases make it difficult for IndexEventListener to do the distinction between an index closed because the node is shutting down and an index closed between it moved away. This commit changes the IndexRemovalReason used when closing the IndicesService to be SHUTDOWN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
IndicesServiceis stopping on a data node, it closes everyIndexServiceinstances that are existing by calling theremoveIndex(Index, IndexRemovalReason, String)method.The
IndexRemovalReasonthat is passed as a parameter in this case isNO_LONGER_ASSIGNEDwhich is also the one passed in other situation like removing an index because it got assigned to another data node. The fact that the same reason is used in multiple cases make it difficult forIndexEventListenerto do the distinction between an index closed because the node is shutting down and an index closed between it moved away.This pull request changes the
IndexRemovalReasonused when closing theIndicesServiceto beCLOSEDthat, I think, better reflect the reason whyIndexServiceare closed.