Add scripted_metric agg context to unsigned_long #64422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also enhance documentation to provide more examples how unsigned_long field should be used in scripts Closes elastic#64347
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
added
>enhancement
v7.11.0
v8.0.0
and removed
Team:Search
|
@elasticmachine run elasticsearch-ci/2 |
|
Stalled because of #64361, until we make a decision how to handle |
|
Is it still needed @mayya-sharipova ? |
|
Hi @mayya-sharipova, I've created a changelog YAML for you. |
|
@elasticmachine run elasticsearch-ci/part-2 |
|
I've added changes based on @stu-elastic's PR #76519. @stu-elastic would appreciate a review from you. |
stu-elastic
reviewed
Feb 2, 2022
| init_script: | | ||
| state.sqrd = [] | ||
| map_script: | | ||
| double v = field('ul').asBigInteger(BigInteger.ZERO).doubleValue(); |
There was a problem hiding this comment.
@stu-elastic Thanks for your feedback. Indeed field API was added in 7.16, but scripted_metric agg context was added to unsigned_long only from 8.1 ( I should correct 8.0 to 8.1).
stu-elastic
approved these changes
Feb 2, 2022
nik9000
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enhance documentation to provide more examples
how unsigned_long field should be used in scripts
Relates to #60050
Closes #64347