Script Error when using unsigned long in a scripted_metric

[hendrikmuhs]

Executing a scripted_metric on an unsigned_long field fails, while the same works for long.

Minimal repro case:

PUT ul_test
{
  "mappings": {
    "properties": {
      "a": {
        "type": "unsigned_long"
      }
    }
  }
}

POST ul_test/_doc/1
{
  "a": 42
}

PUT l_test
{
  "mappings": {
    "properties": {
      "a": {
        "type": "long"
      }
    }
  }
}

POST l_test/_doc/1
{
  "a": 42
}

GET l_test/_search
{
  "aggs": {
    "sqrt": {
      "scripted_metric": {
        "init_script": "state.sqrd = []",
        "map_script": "state.sqrd.add(doc.a.value * doc.a.value)",
        "combine_script": "state.sqrd",
        "reduce_script": "def sum = 0.0; for(l in states){ for(a in l) { sum += a}} return sum"
      }
    }
  }
}

GET ul_test/_search
{
  "aggs": {
    "sqrt": {
      "scripted_metric": {
        "init_script": "state.sqrd = []",
        "map_script": "state.sqrd.add(doc.a.value * doc.a.value)",
        "combine_script": "state.sqrd",
        "reduce_script": "def sum = 0.0; for(l in states){ for(a in l) { sum += a}} return sum"
      }
    }
  }
}

error:

{
  "error" : {
    "root_cause" : [
      {
        "type" : "script_exception",
        "reason" : "runtime error",
        "script_stack" : [
          "state.sqrd.add(doc.a.value * doc.a.value)",
          "                    ^---- HERE"
        ],
        "script" : "state.sqrd.add(doc.a.value * doc.a.value)",
        "lang" : "painless",
        "position" : {
          "offset" : 20,
          "start" : 0,
          "end" : 41
        }
      }
    ],

[elasticmachine]

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

[elasticmachine]

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

[stu-elastic]

Here's the full error:

{
  "error": {
    "root_cause": [
      {
        "type": "script_exception",
        "reason": "runtime error",
        "script_stack": [
          "state.sqrd.add(doc.a.value * doc.a.value)",
          "                    ^---- HERE"
        ],
        "script": "state.sqrd.add(doc.a.value * doc.a.value)",
        "lang": "painless",
        "position": {
          "offset": 20,
          "start": 0,
          "end": 41
        }
      }
    ],
    "type": "search_phase_execution_exception",
    "reason": "all shards failed",
    "phase": "query",
    "grouped": true,
    "failed_shards": [
      {
        "shard": 0,
        "index": "ul_test",
        "node": "fHlNRuAQQz2X-95x7vN53Q",
        "reason": {
          "type": "script_exception",
          "reason": "runtime error",
          "script_stack": [
            "state.sqrd.add(doc.a.value * doc.a.value)",
            "                    ^---- HERE"
          ],
          "script": "state.sqrd.add(doc.a.value * doc.a.value)",
          "lang": "painless",
          "position": {
            "offset": 20,
            "start": 0,
            "end": 41
          },
          "caused_by": {
            "type": "illegal_argument_exception",
            "reason": "Illegal list shortcut value [value]."
          }
        }
      }
    ]
  },
  "status": 400
}

[nik9000]

This is probably worth @mayya-sharipova having a look at. I think we're missing a passlist entry for getValue. For what it is worth it returns a java.lang.Number (either a java.lang.Long or a java.math.BigInteger depending on its size. I don't recall if painless has * and + for Number or not. Maybe worth thinking about. I'm not 100% sure how to add this to the passlist either. We'd want it in pretty much all the contexts if the plugin containing unsigned long is registered.

[stu-elastic]

The DocValuesWhitelistExtension needs to be updated, at least.

[mayya-sharipova]

Thanks for pinging, I will look into this.