Skip to content

Minor Cleanup Dead Code Snapshotting #57716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
original-brownbear merged 3 commits into from
Jun 9, 2020
Merged

Minor Cleanup Dead Code Snapshotting #57716

original-brownbear merged 3 commits into from
Jun 9, 2020

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Jun 5, 2020 •
edited
Loading

  • Use consistent cluster state instead in state update
  • Remove dead loop in tests
  • Remove some dead exception ctors

Just three trivial/random things I found.

@original-brownbear
Minor Cleanup Dead Code Snapshotting
652d8a0 
* Use consistent cluster state instead in state update
* Remove dead loop in tests
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 5, 2020

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 5, 2020
fcofdez
fcofdez approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Jun 9, 2020

Thanks Francisco!

@original-brownbear original-brownbear merged commit 8c8253d into elastic:master Jun 9, 2020
@original-brownbear original-brownbear deleted the cleanup-weirdness-snapshots branch June 9, 2020 14:42
@original-brownbear original-brownbear mentioned this pull request Jul 14, 2020
Merged
original-brownbear added a commit that referenced this pull request Jul 14, 2020
@original-brownbear
Minor Cleanup Dead Code Snapshotting (#57716) (#59569)
68a199f 
* Use consistent cluster state instead in state update
* Remove dead loop in tests
* Remove some dead exception ctors

Just three trivial/random things I found.
@original-brownbear original-brownbear restored the cleanup-weirdness-snapshots branch August 6, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcofdez fcofdez fcofdez approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.9.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@original-brownbear @elasticmachine @fcofdez @jakelandis