Minor Cleanup Dead Code Snapshotting (#57716) (#59569)

* Use consistent cluster state instead in state update
* Remove dead loop in tests
* Remove some dead exception ctors

Just three trivial/random things I found.

Author: original-brownbear

server/src/main/java/org/elasticsearch/index/snapshots/IndexShardSnapshotException.java

@@ -33,11 +33,6 @@ public IndexShardSnapshotException(ShardId shardId, String msg) {
         this(shardId, msg, null);
     }
 
-    public IndexShardSnapshotException(ShardId shardId, Throwable cause) {
-        super(cause);
-        setShard(shardId);
-    }
-
     public IndexShardSnapshotException(ShardId shardId, String msg, Throwable cause) {
         super(msg, cause);
         setShard(shardId);

server/src/main/java/org/elasticsearch/index/snapshots/IndexShardSnapshotFailedException.java

@@ -32,10 +32,6 @@ public IndexShardSnapshotFailedException(ShardId shardId, String msg) {
         super(shardId, msg);
     }
 
-    public IndexShardSnapshotFailedException(ShardId shardId, Throwable cause) {
-        super(shardId, cause);
-    }
-
     public IndexShardSnapshotFailedException(ShardId shardId, String msg, Throwable cause) {
         super(shardId, msg, cause);
     }

server/src/main/java/org/elasticsearch/snapshots/SnapshotsService.java

@@ -362,8 +362,7 @@ public ClusterState execute(ClusterState currentState) {
                 final List<IndexId> indexIds = repositoryData.resolveNewIndices(indices);
                 final List<String> dataStreams =
                         indexNameExpressionResolver.dataStreamNames(currentState, request.indicesOptions(), request.indices());
-                final Version version = minCompatibleVersion(
-                        clusterService.state().nodes().getMinNodeVersion(), repositoryData, null);
+                final Version version = minCompatibleVersion(currentState.nodes().getMinNodeVersion(), repositoryData, null);
                 ImmutableOpenMap<ShardId, ShardSnapshotStatus> shards =
                         shards(currentState, indexIds, useShardGenerations(version), repositoryData);
                 if (request.partial() == false) {

server/src/test/java/org/elasticsearch/snapshots/SnapshotResiliencyTests.java

@@ -615,14 +615,6 @@ public void testBulkSnapshotDeleteWithAbort() {
         Collection<SnapshotId> snapshotIds = getRepositoryData(repository).getSnapshotIds();
         // No snapshots should be left in the repository
         assertThat(snapshotIds, empty());
-
-        for (SnapshotId snapshotId : snapshotIds) {
-            final SnapshotInfo snapshotInfo = repository.getSnapshotInfo(snapshotId);
-            assertEquals(SnapshotState.SUCCESS, snapshotInfo.state());
-            assertThat(snapshotInfo.indices(), containsInAnyOrder(index));
-            assertEquals(shards, snapshotInfo.successfulShards());
-            assertEquals(0, snapshotInfo.failedShards());
-        }
     }
 
     public void testConcurrentSnapshotRestoreAndDeleteOther() {