[Backport] Refactor Spatial Field Mappers #55696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
>non-issue
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
talevy
approved these changes
Apr 23, 2020
This commit refactors all spatial Field Mappers to a common AbstractGeometryFieldMapper that implements shared parameter functionality (e.g., ignore_malformed, ignore_z_value) and provides a common framework for overriding type parsing, and building in xpack. Common shape functionality is implemented in a new AbstractShapeGeometryFieldMapper that is reused and overridden in GeoShapeFieldMapper, GeoShapeFieldMapperWithDocValues, LegacyGeoShapeFieldMapper, and ShapeFieldMapper. This abstraction provides a reusable foundation for adding new xpack features; such as coordinate reference system support.
doing so the doXContentBody for geo_shape types were changed to include the common field mapper parameters (e.g., index, store, term_vector). This introduced a bug that included doc_values twice. This commit removes the explicit inclusion of the doc_values parameter from the GeoShapeWithDocValuesFieldMapper.doXContentBody method.
nknize
force-pushed
the
refactor/SpatialFieldMappers_7x
branch
from
351db83 to
c9b3815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors all spatial Field Mappers to a common
AbstractGeometryFieldMapperthat implements shared parameter functionality(e.g.,
ignore_malformed,ignore_z_value) and provides a common framework foroverriding type parsing, and building in xpack. Common shape functionality is
implemented in a new
AbstractShapeGeometryFieldMapperthat is reused andoverridden in
GeoShapeFieldMapper,GeoShapeFieldMapperWithDocValues,LegacyGeoShapeFieldMapper, andShapeFieldMapper. This abstraction provides areusable foundation for adding new xpack features; such as coordinate reference
system support.