Refactor Spatial Field Mappers #55621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors all spatial Field Mappers to a common AbstractGeometryFieldMapper that implements shared parameter functionality (e.g., ignore_malformed, ignore_z_value) and provides a common framework for overriding type parsing, and building in xpack. Common shape functionality is implemented in a new AbstractShapeGeometryFieldMapper that is reused and overridden in GeoShapeFieldMapper, GeoShapeFieldMapperWithDocValues, LegacyGeoShapeFieldMapper, and ShapeFieldMapper. This abstraction provides a reusable foundation for adding new xpack features; such as coordinate reference system support.
nknize
added
>non-issue
:Analytics/Geo
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
iverase
requested changes
Apr 23, 2020
Contributor
iverase
left a comment
iverase
left a comment
There was a problem hiding this comment.
I love this change, it is awesome that all our geo fields inherit from the same subclass. I would like to explore the use of generics in AbstractGeometryFieldParser.TypeParser to avoid casting on the subclasses, otherwise +1
server/src/main/java/org/elasticsearch/index/mapper/AbstractGeometryFieldMapper.java
Outdated
Show resolved
Hide resolved
talevy
approved these changes
Apr 23, 2020
Contributor
talevy
left a comment
talevy
left a comment
There was a problem hiding this comment.
I like the hierarchy unification as well. thanks for that.
nknize
added a commit
to nknize/elasticsearch
that referenced
this pull request
Apr 24, 2020
This commit refactors all spatial Field Mappers to a common AbstractGeometryFieldMapper that implements shared parameter functionality (e.g., ignore_malformed, ignore_z_value) and provides a common framework for overriding type parsing, and building in xpack. Common shape functionality is implemented in a new AbstractShapeGeometryFieldMapper that is reused and overridden in GeoShapeFieldMapper, GeoShapeFieldMapperWithDocValues, LegacyGeoShapeFieldMapper, and ShapeFieldMapper. This abstraction provides a reusable foundation for adding new xpack features; such as coordinate reference system support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all spatial Field Mappers to a common
AbstractGeometryFieldMapperthat implements shared parameter functionality (e.g.,ignore_malformed,ignore_z_value) and provides a common framework for overriding type parsing, and building in xpack. Common shape functionality is implemented in a newAbstractShapeGeometryFieldMapperthat is reused and overridden inGeoShapeFieldMapper,GeoShapeFieldMapperWithDocValues,LegacyGeoShapeFieldMapper, andShapeFieldMapper, respectively. This abstraction provides a reusable foundation for adding new xpack features; such as coordinate reference system support.