Fix VectorsFeatureSetUsage serialization in BWC mode #55399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While communicating with earlier version of elasticsearch, VectorsFeatureSetUsage is using writeInt instead of writeVInt that 7.x version is expecting. This commit fixes the issue. Fixes elastic#55378
imotov
added
>bug
:Search/Search
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
jtibshirani
approved these changes
Apr 17, 2020
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
Thanks again @imotov for the fix. It's great we have BWC tests now.
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticsearchmachine run elasticsearch-ci/2 |
1 similar comment
Contributor
Author
|
@elasticsearchmachine run elasticsearch-ci/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While communicating with an earlier version of elasticsearch,
VectorsFeatureSetUsage is using writeInt instead of writeVInt that 7.x version
is expecting. This commit fixes the issue.
Fixes #55378