Exclude Snapshot Shard Status Update Requests from Circuit Breaker #55376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix to not run into stuck snapshots because of master circuit breaking these requests. Given that these requests are very small and much of the memory associated with them is already allocated when the circuit breaker kicks in, the risk of this change introducing a higher chance of master running out of memory should be very small. Closes #54714
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
Contributor
Author
|
Jenkins run elasticsearch-ci/1 |
ywelsch
approved these changes
Apr 17, 2020
Contributor
ywelsch
left a comment
ywelsch
left a comment
There was a problem hiding this comment.
LGTM. I've added the 7.7.1 label as this should definitely go to the 7.7 branch (and can be merged as soon as CI is green). If we end up respinning the build candidate for 7.7.0, we can relabel appropriately here (that's the official process).
Contributor
Author
|
Thanks Yannick! |
original-brownbear
deleted the
exclude-snapshot-shard-status-from-breaker
branch
This was referenced Apr 17, 2020
original-brownbear
added a commit
that referenced
this pull request
Apr 17, 2020
…55376) (#55384) Hotfix to not run into stuck snapshots because of master circuit breaking these requests. Given that these requests are very small and much of the memory associated with them is already allocated when the circuit breaker kicks in, the risk of this change introducing a higher chance of master running out of memory should be very small. Closes #54714
original-brownbear
added a commit
that referenced
this pull request
Apr 17, 2020
…55376) (#55383) Hotfix to not run into stuck snapshots because of master circuit breaking these requests. Given that these requests are very small and much of the memory associated with them is already allocated when the circuit breaker kicks in, the risk of this change introducing a higher chance of master running out of memory should be very small. Closes #54714
original-brownbear
restored the
exclude-snapshot-shard-status-from-breaker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix to not run into stuck snapshots because of master circuit breaking these requests.
Given that these requests are very small and much of the memory associated with them is already allocated
when the circuit breaker kicks in, the risk of this change introducing a higher chance of master running out of memory should be very small.
Closes #54714
Note: I didn't add the 7.7.x label here yet since that's still up for discussion. Just opening this to show the simplicity of the fix.