Skip to content

Conversation

@renshuki
Copy link
Contributor

Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)

https://www.elastic.co/guide/en/elasticsearch/painless/current/painless-statements.html

@renshuki renshuki added the >docs General docs changes label Oct 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@ywelsch ywelsch added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Dec 2, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@rjernst rjernst requested a review from jdconrad December 3, 2019 19:03
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renshuki Apologies for the very delayed review. I have requested a few changes if you're still interested in working on this.

@jrodewig
Copy link
Contributor

Hi @renshuki. Do you still plan to address feedback for this PR?

If not, I'll close it. Either way, thanks for your contribution.

@renshuki
Copy link
Contributor Author

@jrodewig @jdconrad Yes I wish continue to work on this PR, I'll push the changes requested by @jdconrad today.

@renshuki
Copy link
Contributor Author

@jdconrad Could you please double check the latest changes? Thanks.

@rjernst rjernst added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels May 4, 2020
@jrodewig jrodewig requested a review from jdconrad May 11, 2020 12:47
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Apologies for the serious delay.

@jdconrad
Copy link
Contributor

@elasticmachine test this please

@jdconrad jdconrad merged commit f281684 into elastic:7.4 May 11, 2020
jdconrad added a commit that referenced this pull request May 11, 2020
jdconrad pushed a commit to jdconrad/elasticsearch that referenced this pull request May 11, 2020
Add more examples to the Painless statements documentation (including while and do...while) as requested in elastic#47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
jdconrad pushed a commit that referenced this pull request May 11, 2020
Add more examples to the Painless statements documentation (including while and do...while) as requested in #47485 (review)
@renshuki
Copy link
Contributor Author

Thanks for the merge @jdconrad ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes feedback_needed Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants