Remove parent query string parameter #41098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the deprecated parent query string parameter. The routing parameter should be used instead.
colings86
added
:Distributed Indexing/CRUD
Collaborator
|
Pinging @elastic/es-distributed |
Collaborator
|
Pinging @elastic/es-search |
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Apr 11, 2019
This commit removes the generated obsolete parameters through code generation. Relates: elastic/elasticsearch#41098
Contributor
|
@elasticmachine run elasticsearch-ci/packaging-sample |
jimczi
pushed a commit
that referenced
this pull request
May 20, 2019
This commit removes the deprecated parent query string parameter. The routing parameter should be used instead.
Contributor
|
Thanks @russcam , I merged in master and 7.x |
Member
|
Hey @jimczi many thanks fo pulling this in. For 7.x I don't think we can do a hard remove for similar reasons as outlined here: |
Contributor
|
@jimczi Please remember to add all relevant labels (area label, version label(s) and change type label) on all PRs and please look for this as part of reviews. The release note generation process is made much harder when PRs are not labelled correctly. |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This commit removes the deprecated parent query string parameter. The routing parameter should be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the deprecated
parentquery string parameter. The routing parameter should be used instead.