Remove generated [Obsolete] parameters #3659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the generated obsolete parameters through code generation. Once elastic/elasticsearch/#41098 is merged, this can be updated to pull in new REST API specs and revert the `[Obsolete]` param removal impl
…to 7x/obsolete # Conflicts: # src/Nest/Search/Search/SearchResponse.cs
Mpdreamz
requested changes
Apr 11, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
+22 −432 love that ratio 😄
I don't think we should continue on obsolete in the codegeneration, instead we need to introduce *.patch.json files or code configuration to skip parent.
Will look into amending this today
src/CodeGeneration/ApiGenerator/Domain/ApiQueryParametersPatcher.cs
Outdated
Show resolved
Hide resolved
russcam
commented
Apr 11, 2019
| public override IEnumerable<string> SkipQueryStringParams { get; } = new[] | ||
| { | ||
| "parent", //can be removed once https://github.com/elastic/elasticsearch/pull/41098 is in | ||
| "copy_settings", //this still needs a PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the generated obsolete parameters through code generation.
Kept the
[Obsolete]Mappings for the moment.Once elastic/elasticsearch#41098 is merged, this can be updated to pull in new
REST API specs and revert the
[Obsolete]param removal implementation.