Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overlapping, before, after filters to intervals query #38999

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Add overlapping, before, after filters to intervals query #38999

merged 1 commit into from
Feb 18, 2019

Conversation

romseygeek
Copy link
Contributor

Lucene recently added overlapping, before and after filters to the intervals package. This
commit exposes them in elasticsearch.

@romseygeek romseygeek added >feature :Search/Search Search-related issues that do not fall into other categories v7.2.0 labels Feb 16, 2019
@romseygeek romseygeek self-assigned this Feb 16, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

jimczi
jimczi approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 8c2c1cb into elastic:master Feb 18, 2019
@romseygeek romseygeek deleted the more-interval-filters branch February 18, 2019 14:44
romseygeek added a commit that referenced this pull request Feb 18, 2019
@romseygeek
Add overlapping, before, after filters to intervals query (#38999)
ab4d5f4 
Lucene recently added `overlapping`, `before` and `after` filters to the intervals package. This
commit exposes them in elasticsearch.
@romseygeek romseygeek mentioned this pull request Feb 18, 2019
Merged
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 18, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into retention-lease-st…
8433480 
…ate-file

* elastic/master:
  Remove tests and branches that will never execute (elastic#38772)
  also check ccr stats api return empty response in ensureNoCcrTasks()
  Add overlapping, before, after filters to intervals query (elastic#38999)
  Mute test elastic#38949
  Add remote recovery to ShardFollowTaskReplicationTests (elastic#39007)
  [ML] More advanced post-test cleanup of ML indices (elastic#39049)
  wait for shard to be allocated before executing a resume follow api
  Update track-total-hits.asciidoc
  Force kill testcluster nodes (elastic#37353)
  Make pullFixture a task dependency of resolveAllDependencies (elastic#38956)
  set minimum supported version (elastic#39043)
  Enforce Completion Context Limit (elastic#38675)
  Mute test
  Don't close caches while there might still be in-flight requests. (elastic#38958)
  Fix elastic#38623 remove xpack namespace REST API (elastic#38625)
  Add data frame feature (elastic#38934)
  Test bi-directional index following during a rolling upgrade. (elastic#38962)
  Generate mvn pom for ssl-config library (elastic#39019)
  Mute testRetentionLeaseIsRenewedDuringRecovery
romseygeek added a commit that referenced this pull request Feb 19, 2019
@romseygeek
Adjust backwards-compatibility versions for before,after,overlapping …
3f8e022 
…interval filters (#39062)

Follow up to #38999, this commit re-enables backwards-compatibility REST tests
for `before`, `after` and `overlapping` filters against versions 7.1 and up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi jimczi approved these changes

@mayya-sharipova mayya-sharipova Awaiting requested review from mayya-sharipova

Assignees

@romseygeek romseygeek

Labels
>feature :Search/Search Search-related issues that do not fall into other categories v7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romseygeek @elasticmachine @jimczi