Fix #38623 remove xpack namespace REST API #38625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasontedor @jakelandis preferences for updating the YAML tests? Can do a follow up PR or add commits to this one to do so. |
|
Closing for now, realized I need to do more due diligence as I stepped outside. Don't want to waste anyone's time while I'm out. Will reopen later today when ready. |
|
Updated the names inside the yaml files as well as their references in the various yaml test suites. This shoul now be ready for review. |
|
Pinging @elastic/es-core-infra |
danielmitterdorfer
added
>bug
blocker
v7.0.0
v8.0.0
v7.2.0
and removed
>enhancement
labels
|
run elasticsearch-ci/1 |
There was a problem hiding this comment.
Looks fine overall. I found a few more references in
elasticsearch/docs/build.gradle
Line 843 in 7b907c1
|
Correct @danielmitterdorfer thought i caught all of those 👍 Updated the PR. |
danielmitterdorfer
approved these changes
Feb 14, 2019
|
run elasticsearch-ci/bwc |
|
@Mpdreamz I think you'll need to merge master in to get |
Except for xpack.usage and xpack.info API's, this moves the last remaining API's out of the xpack namespace
Mpdreamz
force-pushed
the
fix/rest-spec-namespaces
branch
from
140bdec to
1af538c
Compare
|
Thanks @atorok rebased against master 🤞 |
|
run elasticsearch-ci/2 |
Mpdreamz
added a commit
to Mpdreamz/elasticsearch
that referenced
this pull request
Feb 18, 2019
* Fix elastic#38623 remove xpack namespace REST API Except for xpack.usage and xpack.info API's, this moves the last remaining API's out of the xpack namespace * rename xpack api's inside inside the files as well * updated yaml tests references to xpack namespaces api's * update callsApi calls in the IT subclasses * make sure docs testing does not use xpack namespaced api's * fix leftover xpack namespaced method names in docs/build.gradle * found another leftover reference (cherry picked from commit ccb5d93)
Mpdreamz
added a commit
to Mpdreamz/elasticsearch
that referenced
this pull request
Feb 18, 2019
* Fix elastic#38623 remove xpack namespace REST API Except for xpack.usage and xpack.info API's, this moves the last remaining API's out of the xpack namespace * rename xpack api's inside inside the files as well * updated yaml tests references to xpack namespaces api's * update callsApi calls in the IT subclasses * make sure docs testing does not use xpack namespaced api's * fix leftover xpack namespaced method names in docs/build.gradle * found another leftover reference (cherry picked from commit ccb5d93)
Mpdreamz
added a commit
that referenced
this pull request
Feb 18, 2019
* Fix #38623 remove xpack namespace REST API Except for xpack.usage and xpack.info API's, this moves the last remaining API's out of the xpack namespace * rename xpack api's inside inside the files as well * updated yaml tests references to xpack namespaces api's * update callsApi calls in the IT subclasses * make sure docs testing does not use xpack namespaced api's * fix leftover xpack namespaced method names in docs/build.gradle * found another leftover reference (cherry picked from commit ccb5d93)
Mpdreamz
added a commit
that referenced
this pull request
Feb 18, 2019
* Fix #38623 remove xpack namespace REST API Except for xpack.usage and xpack.info API's, this moves the last remaining API's out of the xpack namespace * rename xpack api's inside inside the files as well * updated yaml tests references to xpack namespaces api's * update callsApi calls in the IT subclasses * make sure docs testing does not use xpack namespaced api's * fix leftover xpack namespaced method names in docs/build.gradle * found another leftover reference (cherry picked from commit ccb5d93)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 18, 2019
…ate-file * elastic/master: Remove tests and branches that will never execute (elastic#38772) also check ccr stats api return empty response in ensureNoCcrTasks() Add overlapping, before, after filters to intervals query (elastic#38999) Mute test elastic#38949 Add remote recovery to ShardFollowTaskReplicationTests (elastic#39007) [ML] More advanced post-test cleanup of ML indices (elastic#39049) wait for shard to be allocated before executing a resume follow api Update track-total-hits.asciidoc Force kill testcluster nodes (elastic#37353) Make pullFixture a task dependency of resolveAllDependencies (elastic#38956) set minimum supported version (elastic#39043) Enforce Completion Context Limit (elastic#38675) Mute test Don't close caches while there might still be in-flight requests. (elastic#38958) Fix elastic#38623 remove xpack namespace REST API (elastic#38625) Add data frame feature (elastic#38934) Test bi-directional index following during a rolling upgrade. (elastic#38962) Generate mvn pom for ssl-config library (elastic#39019) Mute testRetentionLeaseIsRenewedDuringRecovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for xpack.usage and xpack.info API's, this moves the last remaining API's out of the xpack namespace.
Need to distinguish
xpack.infofrominfohttps://github.com/elastic/elasticsearch/blob/master/rest-api-spec/src/main/resources/rest-api-spec/api/info.jsonSince both these API's are quite clearly relay details about
x-packI am fine with leaving these in the x-pack namespace.cc @elastic/es-clients
Closes #38623