CORE: Disable Setting Type Validation#33660
Merged
original-brownbear merged 1 commit intoelastic:6.xfrom Sep 13, 2018
Merged
Conversation
Contributor
original-brownbear
commented
Sep 13, 2018
original-brownbear
commented
- Reverts setting type validation introduced in CORE: Validate Type for String Settings #33503
* Reverts setting type validation introduced in #33503
original-brownbear
added
>non-issue
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
s1monw
approved these changes
Sep 13, 2018
Contributor
s1monw
left a comment
s1monw
left a comment
There was a problem hiding this comment.
This must go into master too. This validation is broken. We also need a test that shows it imo but merge it first to unblock others
Contributor
Author
|
@s1monw thanks, will merge once green and look into the validation next then :) |
Member
|
Sorry @original-brownbear for the trouble with the backport. |
Contributor
Author
|
@jasontedor np :) version for master incoming here #33669 <= put version labels on that PR now |
original-brownbear
added a commit
that referenced
this pull request
Sep 13, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 13, 2018
…polling * elastic/master: SQL: Return correct catalog separator in JDBC (elastic#33670) [CCR] Add validation for max_retry_delay (elastic#33648) [CCR] Add monitoring mapping verification test (elastic#33662) CORE: Disable Setting Type Validation (elastic#33660) (elastic#33669) Revert "Use serializable exception in GCP listeners (elastic#33657)" Adding index refresh (elastic#33647) [DOCS] Moves securing-communications to docs (elastic#33640) [HLRC][ML] Add ML delete datafeed API to HLRC (elastic#33667) Mute testRecoveryWithConcurrentIndexing TEST: decrease logging level in the flush test DOC: Add SQL section on client applications Fix race in global checkpoint listeners test Use serializable exception in GCP listeners (elastic#33657)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.