[CCR] Add validation for max_retry_delay#33648
Merged
martijnvg merged 2 commits intoelastic:masterfrom Sep 13, 2018
Merged
Conversation
martijnvg
added
review
:Distributed/CCR
Collaborator
|
Pinging @elastic/es-distributed |
jasontedor
reviewed
Sep 12, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
Looks good, I left a question about the content of the message though.
| ActionRequestValidationException validationException = null; | ||
|
|
||
| if (maxRetryDelay.millis() <= 0) { | ||
| String message = "maxRetryDelay must be positive but was [" + maxRetryDelay.getStringRep() + "]"; |
Member
There was a problem hiding this comment.
Maybe the message should be centered around the REST parameter max_retry_delay as this is the common usage?
martijnvg
added a commit
that referenced
this pull request
Sep 13, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 13, 2018
…polling * elastic/master: SQL: Return correct catalog separator in JDBC (elastic#33670) [CCR] Add validation for max_retry_delay (elastic#33648) [CCR] Add monitoring mapping verification test (elastic#33662) CORE: Disable Setting Type Validation (elastic#33660) (elastic#33669) Revert "Use serializable exception in GCP listeners (elastic#33657)" Adding index refresh (elastic#33647) [DOCS] Moves securing-communications to docs (elastic#33640) [HLRC][ML] Add ML delete datafeed API to HLRC (elastic#33667) Mute testRecoveryWithConcurrentIndexing TEST: decrease logging level in the flush test DOC: Add SQL section on client applications Fix race in global checkpoint listeners test Use serializable exception in GCP listeners (elastic#33657)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.