Fix using relative custom config path #28700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a user could set a custom config path to a relative directory using ES_PATH_CONF. In a previous change related to enabling GC logging by default, we forced the working directory for Elasticsearch to be ES_HOME. This had the impact of causing all relative paths to be relative to ES_HOME, against the intent of the user. This commit addresses this by making ES_PATH_CONF absolute before we switch the working directory to ES_HOME.
jasontedor
added
>bug
review
:Delivery/Packaging
Member
Author
|
run the packaging tests |
Contributor
|
@jasontedor you could use readlink too instead of cd |
Member
Author
|
@hub-cap |
Contributor
|
🤦♂️ makes sense @jasontedor |
jasontedor
added a commit
that referenced
this pull request
Feb 16, 2018
Previously a user could set a custom config path to a relative directory using ES_PATH_CONF. In a previous change related to enabling GC logging by default, we forced the working directory for Elasticsearch to be ES_HOME. This had the impact of causing all relative paths to be relative to ES_HOME, against the intent of the user. This commit addresses this by making ES_PATH_CONF absolute before we switch the working directory to ES_HOME. Relates #28700
jasontedor
added a commit
that referenced
this pull request
Feb 16, 2018
Previously a user could set a custom config path to a relative directory using ES_PATH_CONF. In a previous change related to enabling GC logging by default, we forced the working directory for Elasticsearch to be ES_HOME. This had the impact of causing all relative paths to be relative to ES_HOME, against the intent of the user. This commit addresses this by making ES_PATH_CONF absolute before we switch the working directory to ES_HOME. Relates #28700
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a user could set a custom config path to a relative directory using
ES_PATH_CONF. In a previous change related to enabling GC logging by default, we forced the working directory for Elasticsearch to beES_HOME. This had the impact of causing all relative paths to be relative toES_HOME, against the intent of the user. This commit addresses this by makingES_PATH_CONFabsolute before we switch the working directory toES_HOME.Relates #27610