Enable GC logs by default #27610
Merged
Enable GC logs by default #27610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For too long we have been groping around in the dark when faced with GC issues because we rarely have GC logs at our disposal. This commit enables GC logging by default out of the box.
jasontedor
added
:Delivery/Packaging
danielmitterdorfer
approved these changes
Dec 1, 2017
Member
danielmitterdorfer
left a comment
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Great to have this on by default now! The activated options are a good start IMHO.
Does it make sense to briefly mention this in the docs (that they are on by default, configured in config/jvm.options and they take up to 2GB of space)?
LGTM.
Member
Author
|
@danielmitterdorfer I pushed docs in a166455 if you want to take a look? |
Member
Thanks! LGTM. |
jasontedor
added a commit
that referenced
this pull request
Dec 3, 2017
For too long we have been groping around in the dark when faced with GC issues because we rarely have GC logs at our disposal. This commit enables GC logging by default out of the box. Relates #27610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For too long we have been groping around in the dark when faced with GC issues because we rarely have GC logs at our disposal. This commit enables GC logging by default out of the box.
@danielmitterdorfer Please review the GC log settings.
@rjernst Please review the packaging changes.