-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Add allow_partial_search_results flag to search requests with default setting true #28440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Initial commit here just for CI checking that forward-port of 6.x-based #27906 was successful. Once green I'll add a commit that changes the default for |
80a1cdc to
56a2746
Compare
colings86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments int eh tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why this is needed? This test doesn't appear to test partial results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a necessity from a previously failing trial on 6.x - if I recall correctly it was for searches that rely on the use of field data. Ditto the other test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why this is needed? This test doesn't appear to test partial results?
1f68b79 to
e9606f3
Compare
|
Reverted the code that defaults searches to strict (error on partial results). Will open a separate issue once this is pushed to consider changing the default to strict. |
|
CI build failures look to all be related to BWC checks with the 6.3 snapshot that doesn't yet have the new allowPartialSearchResults flag serializing in SearchRequest |
|
If I can assist in integrating a change like this with cross-cutting BWC implications, please let me know. I am always happy to help. |
|
@jasontedor Thanks for the offer of help. I have 2 PRs lined up ready to push (if I can get an OK on this one, @colings86 ?)
Not sure if there needs to be a gap between 1) and 2) waiting for the 6.x build to make it through the intake tests? After all this is done I'll open a separate issue to open the debate on whether new cluster default setting is to fail on partial results. |
colings86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@markharwood I think that this would help keep the build green every step of the way and let you integrate this at a leisurely pace:
|
… setting = true. When false, will error if search either timeouts, has partial errors or has missing shards rather than returning partial search results. A cluster-level setting provides a default for searches with no flag. Closes elastic#27435
e9606f3 to
0f34b2a
Compare
When false, will error if search either timeouts, has partial errors or has missing shards rather
than returning partial search results. A cluster-level setting provides a default for searches
with no flag.
Closes #27435