Search - new flag: allow_partial_search_results #27691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
the
:Search/Search
Contributor
Author
|
jenkins test this |
markharwood
force-pushed
the
fix/27435
branch
3 times, most recently
from
85b7741 to
d1f3fa1
Compare
…ial_search_results Breaking change which means searches that used to produce partial results will now fail with an error. Closes elastic#27435
markharwood
force-pushed
the
fix/27435
branch
from
5f8d7e3 to
d62cd97
Compare
Contributor
Author
|
jenkins test this |
Contributor
Author
|
Closing. Duplicate of #28440 which was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow searches to fail if they are missing results eg from a timeout or a failure to execute on at least one shard. The allow_partial_search_results flag is a new parameter on search headers and a cluster-level setting controls default behaviour of searches where no preference is passed in the request. In future versions we will change the cluster default setting to throw errors instead of returning partial results.
This initial PR is currently missing support for checking red indices (missing shards) and docs - submitting here for initial Jenkins testing.
Closes #27435