Update indices settings api to support CBOR and SMILE format #23309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also expand testing on the different ways to provide index settings and remove dead code around ability to provide settings as query string parameters Closes elastic#23242
javanna
added
:Core/Infra/Settings
jaymode
approved these changes
Feb 22, 2017
javanna
added a commit
that referenced
this pull request
Feb 22, 2017
Also expand testing on the different ways to provide index settings and remove dead code around ability to provide settings as query string parameters Closes #23242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indices update settings api should support requests in binary formats like cbor or smile, not just json or yaml. Also expanded testing on the different ways to provide index settings and remove dead code around ability to provide settings as query string parameters. The latter didn't work since 5.0 , where we introduced validation of query_string parameters. Given that we received no complaint about that, rather than restoring that ability, I will add a note to the 5.0 migration guide.
Relates to #23245
Closes #23242