Skip to content

[ESQL] Fix filter pushdown review nits #145924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
costin wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −10
Open

[ESQL] Fix filter pushdown review nits #145924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7475acb
ESQL: Fix filter pushdown review nits
costin Apr 8, 2026
867aa7c
Update docs/changelog/145924.yaml
costin Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/145924.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
area: ES|QL
issues: []
pr: 145924
summary: Fix filter pushdown review nits
type: enhancement
15 changes: 5 additions & 10 deletions ...ain/java/org/elasticsearch/xpack/esql/datasources/AsyncExternalSourceOperatorFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ private FormatReader readerForFile(FileSplit fileSplit) {
fileColumnNames.add(name);
DataType castTarget = mapping.cast(i);
if (castTarget != null) {
DataType fileType = inferFileType(attributes.get(i).dataType(), castTarget);
DataType fileType = inferFileType(castTarget);
if (fileType != null) {
fileColumnTypes.put(name, fileType);
}
Expand All @@ -517,21 +517,16 @@ private FormatReader readerForFile(FileSplit fileSplit) {
return formatReader.withPushedFilter(null);
}

/**
* Infers the file's native type from the unified attribute type and the cast target.
* The cast target is the unified (wider) type; the file has the narrower type.
*/
/**
* Infers the file's native type from the cast target. Only returns a narrower type when
* the adaptation is safe for integral comparisons (LONG→INTEGER). DOUBLE→INTEGER narrowing
* is not supported because literal truncation can cause incorrect predicate semantics.
* the adaptation is safe for integral comparisons (LONG→INTEGER).
* DOUBLE→INTEGER narrowing is not supported because {@code Number.longValue()} truncates
* fractional values, which changes comparison semantics (e.g., {@code col < 2.7} vs {@code col < 2}).
*/
private static DataType inferFileType(DataType unifiedType, DataType castTarget) {
private static DataType inferFileType(DataType castTarget) {
if (castTarget == DataType.LONG) {
return DataType.INTEGER;
}
// DOUBLE→INTEGER narrowing is intentionally not supported: Number.longValue() truncates
// fractional values, which can change comparison semantics (e.g., col < 2.7 vs col < 2).
return null;
}

Expand Down
Loading