Skip to content

[ESQL] Fix filter pushdown review nits#145924

Open
costin wants to merge 2 commits intoelastic:mainfrom
costin:esql/fix-filter-pushdown-nits
Open

[ESQL] Fix filter pushdown review nits#145924
costin wants to merge 2 commits intoelastic:mainfrom
costin:esql/fix-filter-pushdown-nits

Conversation

@costin
Copy link
Copy Markdown
Member

@costin costin commented Apr 8, 2026

Address review feedback from #145755:

  • Merge duplicate javadoc blocks on inferFileType
  • Move inline comment into javadoc
  • Remove unused unifiedType parameter

Developed with AI-assisted tooling

Merge duplicate javadoc blocks on inferFileType, move inline
comment into javadoc, and remove unused unifiedType parameter.
@costin costin requested a review from bpintea April 8, 2026 17:16
@costin costin enabled auto-merge (squash) April 8, 2026 17:17
@elasticsearchmachine elasticsearchmachine added v9.5.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 8, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @costin, I've created a changelog YAML for you.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >enhancement ES|QL|DS ES|QL datasources Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants