Skip to content

ESQL: enable Generative IT after more fixes #145112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 8 commits into from
Mar 31, 2026
Merged

ESQL: enable Generative IT after more fixes #145112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f4f7ad7
Unmute Generative testing after merging https://github.com/elastic/el…
astefan Mar 27, 2026
ff3b9c7
Ignore internally generated fields by the approximation pipeline
astefan Mar 27, 2026
3b11298
Merge branch 'main' into generativeIT_refine8
astefan Mar 27, 2026
73f2b18
Merge branch 'main' into generativeIT_refine8
astefan Mar 28, 2026
4a82cd6
Merge branch 'main' into generativeIT_refine8
astefan Mar 30, 2026
46b0a5a
Merge branch 'main' into generativeIT_refine8
astefan Mar 30, 2026
32d5469
Merge branch 'main' into generativeIT_refine8
astefan Mar 30, 2026
77efc9f
Merge branch 'main' into generativeIT_refine8
astefan Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...ver/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,11 @@ public abstract class GenerativeRestTest extends ESRestTestCase implements Query
"long overflow", // https://github.com/elastic/elasticsearch/issues/135759
"can't find input for", // https://github.com/elastic/elasticsearch/issues/136596
"optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/138231
// https://github.com/elastic/elasticsearch/issues/142537 for null arguments in clamp() function
"'field' must not be null in clamp\\(\\)", // clamp/clamp_min/clamp_max reject NULL field from unmapped fields
"must be \\[boolean, date, ip, string or numeric except unsigned_long or counter types\\]", // type mismatch in top() arguments
"unsupported logical plan node \\[Join\\]", // https://github.com/elastic/elasticsearch/issues/141978
"Unsupported right plan for lookup join \\[Eval\\]", // https://github.com/elastic/elasticsearch/issues/141870
"Does not support yet aggregations over constants", // https://github.com/elastic/elasticsearch/issues/118292
"found value \\[.*\\] type \\[unsupported\\]", // https://github.com/elastic/elasticsearch/issues/142761
"change point value \\[.*\\] must be numeric", // https://github.com/elastic/elasticsearch/issues/142858
"illegal query_string option \\[boost\\]", // https://github.com/elastic/elasticsearch/issues/142758
"Field \\[.*\\] of type \\[.*\\] does not support match.* queries",
"JOIN left field \\[.*\\] of type \\[NULL\\] is incompatible with right", // https://github.com/elastic/elasticsearch/issues/141827
// https://github.com/elastic/elasticsearch/issues/141827
Expand Down
2 changes: 1 addition & 1 deletion ...testFixtures/src/main/java/org/elasticsearch/xpack/esql/generator/EsqlQueryGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public static String randomName(List<Column> previousOutput) {
}

public static boolean needsQuoting(String rawName) {
return rawName.contains("`") || rawName.contains("-");
return rawName.contains("`") || rawName.contains("-") || rawName.contains("(") || rawName.contains(")");
}

/**
Expand Down
Loading