-
Notifications
You must be signed in to change notification settings - Fork 25.8k
ESQL: propagate empty local relation past joins #144826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fcad2df
Propagate empty relations past joins
astefan 167ca7e
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan acf3a10
Update
astefan 185a380
Update docs/changelog/144826.yaml
astefan ccbe152
More tests
astefan 0005136
Merge branch '144329_fix' of https://github.com/astefan/elasticsearch…
astefan f115c15
Add capability
astefan 6f041ac
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan 2ac039b
Merge branch 'main' into 144329_fix
astefan 8744188
Merge branch 'main' into 144329_fix
astefan 98c8c18
Merge branch 'main' into 144329_fix
astefan 20f9460
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan 01384e8
Add more tests, according to reviews
astefan fa8869f
Merge branch 'main' into 144329_fix
astefan 19654a5
Clean up leftover
astefan b45f7dc
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan 7c2863f
Merge branch '144329_fix' of https://github.com/astefan/elasticsearch…
astefan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| area: ES|QL | ||
| issues: | ||
| - 144329 | ||
| pr: 144826 | ||
| summary: Propagate empty local relation past joins | ||
| type: bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth adding a test with a filter on
null(WHERE null,EVAL x = NULL | WHERE x::int > 0or along the lines)?