Skip to content

ESQL: propagate empty local relation past joins#144826

Merged
elasticsearchmachine merged 17 commits intoelastic:mainfrom
astefan:144329_fix
Mar 27, 2026
Merged

ESQL: propagate empty local relation past joins#144826
elasticsearchmachine merged 17 commits intoelastic:mainfrom
astefan:144329_fix

Conversation

@astefan
Copy link
Copy Markdown
Contributor

@astefan astefan commented Mar 24, 2026

Fixes #144329
AI-assisted PR

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @astefan, I've created a changelog YAML for you.

6.000000000000001 | 1.98
;

multiStatsAfterFalseFilter_ByComputedValues
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We simply didn't have any such tests before. They are not strictly related to the fix in this PR

@astefan astefan marked this pull request as ready for review March 24, 2026 09:15
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Mar 24, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@astefan astefan requested review from alex-spies and ioanatia March 24, 2026 10:33
@astefan astefan requested review from bpintea and removed request for ioanatia March 25, 2026 16:05
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding a test with a filter on null (WHERE null, EVAL x = NULL | WHERE x::int > 0 or along the lines)?

Copy link
Copy Markdown
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astefan astefan added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 27, 2026
@elasticsearchmachine elasticsearchmachine merged commit b909c6c into elastic:main Mar 27, 2026
36 checks passed
@astefan astefan deleted the 144329_fix branch March 27, 2026 12:47
astefan added a commit to astefan/elasticsearch that referenced this pull request Mar 27, 2026
and after several other issues were fixed.
mamazzol pushed a commit to mamazzol/elasticsearch that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESQL: multi_match after lookup join with a FALSE where results in AssertionError

3 participants