Disable ndjson datasource QA tests in release-tests#143992
Merged
costin merged 6 commits intoelastic:mainfrom Mar 12, 2026
Merged
Disable ndjson datasource QA tests in release-tests#143992costin merged 6 commits intoelastic:mainfrom
costin merged 6 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
v9.4.0
needs:triage
swallez
approved these changes
Mar 11, 2026
costin
force-pushed
the
fix/ndjson-qa-default-distribution
branch
from
7cf4864 to
a871584
Compare
costin
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
costin
force-pushed
the
fix/ndjson-qa-default-distribution
branch
from
a871584 to
4073ef1
Compare
costin
changed the title
The release-tests CI pipeline runs with -Dbuild.snapshot=false, which makes isDevVersion() return false and disables the EXTERNAL command in the ESQL grammar. The ndjson QA module was missing the snapshotBuild guard that other datasource modules already had. Also fix StoragePathTests.testFileUriFunction to be platform-agnostic by dynamically constructing expected URIs instead of hardcoding Unix paths. Closes elastic#143979
costin
force-pushed
the
fix/ndjson-qa-default-distribution
branch
from
4073ef1 to
454be31
Compare
costin
changed the title
6 tasks
Member
Author
|
The CI keeps failing due to unrelated tests, I've raised #144086 and will merge this PR. |
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 12, 2026
…elocations * upstream/main: (49 commits) CCS logging fixes (elastic#144070) Improve CPS cluster exclusion handling (elastic#143488) Remove snapshot condition now that node_reduce phase is in non-snapshot builds (elastic#144090) Drop deprecation warnings when updating a mapping in the cluster state applier (elastic#143884) (elastic#144040) Add ensureGreenAndNoInitializingShards helper (elastic#144044) Removed unnecessary applies_to blocks from deprecated query (elastic#144096) [CPS] Use single CrossProjectModeDecider instance (elastic#144030) Fix ESQL TS requests with LIMIT 0 (elastic#144031) ESQL: Remove `create` methods in aggs (elastic#144098) ES|QL: Refactor ChangeLimitOperator (elastic#144017) Add Paginated Hit Source Tests (elastic#142592) Fix test failure not preferred (elastic#144019) Remove serialization logic from EIS authorization response (elastic#144021) ESQL: CSV schema inference and parsing enhancements (elastic#144050) ESQL: Fix incorrectly optimized fork with nullify unmapped_fields (elastic#143030) Fix MMR release test using subqueries (elastic#144087) Refactoring `UserAgentPlugin` (elastic#140712) Drop non-finite samples in Prometheus remote write (elastic#144055) [TEST] Wait for internal inference indices to be created in authorization IT (elastic#143885) Disable ndjson datasource QA tests in release-tests (elastic#143992) ...
michalborek
pushed a commit
to michalborek/elasticsearch
that referenced
this pull request
Mar 23, 2026
The release-tests CI pipeline (`.buildkite/scripts/release-tests.sh`) runs with `-Dbuild.snapshot=false`, simulating a release build. This causes `Build.current().isSnapshot()` to return `false`, which makes `EsqlConfig.isDevVersion()` return `false`, disabling the `EXTERNAL` command in the ESQL ANTLR grammar (`{this.isDevVersion()}? externalCommand`).
The **ndjson** QA module was missing the `enabled = buildParams.snapshotBuild` guard that all other datasource QA modules already had, so its `EXTERNAL`-based tests ran in release-tests and failed with `mismatched input 'EXTERNAL'`.
This PR adds the snapshot guard, consistent with csv, parquet, orc, iceberg, grpc, and gcs.
Also fixes `StoragePathTests.testFileUriFunction` to be platform-agnostic by dynamically constructing expected URIs instead of hardcoding Unix paths (fixes elastic#143979).
Closes elastic#143979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release-tests CI pipeline (
.buildkite/scripts/release-tests.sh) runs with-Dbuild.snapshot=false, simulating a release build. This causesBuild.current().isSnapshot()to returnfalse, which makesEsqlConfig.isDevVersion()returnfalse, disabling theEXTERNALcommand in the ESQL ANTLR grammar ({this.isDevVersion()}? externalCommand).The ndjson QA module was missing the
enabled = buildParams.snapshotBuildguard that all other datasource QA modules already had, so itsEXTERNAL-based tests ran in release-tests and failed withmismatched input 'EXTERNAL'.This PR adds the snapshot guard, consistent with csv, parquet, orc, iceberg, grpc, and gcs.
Also fixes
StoragePathTests.testFileUriFunctionto be platform-agnostic by dynamically constructing expected URIs instead of hardcoding Unix paths (fixes #143979).Changes
esql-datasource-ndjson/qa/build.gradle: addenabled = buildParams.snapshotBuildStoragePathTests.java: maketestFileUriFunctionplatform-agnosticCloses #143979