Skip to content

Add Paginated Hit Source Tests#142592

Merged
elasticsearchmachine merged 12 commits intoelastic:mainfrom
joshua-adams-1:spacetime-paginated-hit-source
Mar 12, 2026
Merged

Add Paginated Hit Source Tests#142592
elasticsearchmachine merged 12 commits intoelastic:mainfrom
joshua-adams-1:spacetime-paginated-hit-source

Conversation

@joshua-adams-1
Copy link
Copy Markdown
Contributor

Adds tests for the subclasses of PaginatedHitSource, including BasicHit,
Response, SearchFailure unit tests and SearchFailure wire
serialisation tests

These were generated via an LLM for a SpaceTime project

Adds tests for the subclasses of PaginatedHitSource, including NasicHit,
 Response, SearchFailure unit tests and Search Failure wire
 serialisation tests
@joshua-adams-1 joshua-adams-1 self-assigned this Feb 17, 2026
@joshua-adams-1 joshua-adams-1 added the >test Issues or PRs that are addressing/adding tests label Feb 17, 2026
@joshua-adams-1 joshua-adams-1 changed the title Spacetime paginated hit source Spacetime paginated hit source tests Feb 17, 2026
@joshua-adams-1 joshua-adams-1 marked this pull request as ready for review February 17, 2026 13:23
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Feb 17, 2026
@joshua-adams-1 joshua-adams-1 added the :Distributed/Reindex Issues relating to reindex that are not caused by issues further down label Feb 17, 2026
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team. and removed needs:triage Requires assignment of a team area label labels Feb 17, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@joshua-adams-1 joshua-adams-1 changed the title Spacetime paginated hit source tests Add Paginated Hit Source Tests Feb 19, 2026
Copy link
Copy Markdown
Contributor

@szybia szybia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the conversation!

@joshua-adams-1 joshua-adams-1 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 12, 2026
@elasticsearchmachine elasticsearchmachine merged commit b6830a0 into elastic:main Mar 12, 2026
36 checks passed
@joshua-adams-1 joshua-adams-1 deleted the spacetime-paginated-hit-source branch March 12, 2026 14:20
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 12, 2026
…elocations

* upstream/main: (49 commits)
  CCS logging fixes (elastic#144070)
  Improve CPS cluster exclusion handling (elastic#143488)
  Remove snapshot condition now that node_reduce phase is in non-snapshot builds (elastic#144090)
  Drop deprecation warnings when updating a mapping in the cluster state applier (elastic#143884) (elastic#144040)
  Add ensureGreenAndNoInitializingShards helper (elastic#144044)
  Removed unnecessary applies_to blocks from deprecated query (elastic#144096)
  [CPS] Use single CrossProjectModeDecider instance (elastic#144030)
  Fix ESQL TS requests with LIMIT 0 (elastic#144031)
  ESQL: Remove `create` methods in aggs (elastic#144098)
  ES|QL: Refactor ChangeLimitOperator (elastic#144017)
  Add Paginated Hit Source Tests (elastic#142592)
  Fix test failure not preferred (elastic#144019)
  Remove serialization logic from EIS authorization response (elastic#144021)
  ESQL: CSV schema inference and parsing enhancements (elastic#144050)
  ESQL: Fix incorrectly optimized fork with nullify unmapped_fields (elastic#143030)
  Fix MMR release test using subqueries (elastic#144087)
  Refactoring `UserAgentPlugin` (elastic#140712)
  Drop non-finite samples in Prometheus remote write (elastic#144055)
  [TEST] Wait for internal inference indices to be created in authorization IT (elastic#143885)
  Disable ndjson datasource QA tests in release-tests (elastic#143992)
  ...
michalborek pushed a commit to michalborek/elasticsearch that referenced this pull request Mar 23, 2026
Adds tests for the subclasses of `PaginatedHitSource`, including
`BasicHit`, `Response`, `SearchFailure` unit tests and `SearchFailure`
wire  serialisation tests

These were generated via an LLM for a SpaceTime project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Reindex Issues relating to reindex that are not caused by issues further down Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants