Skip to content

Fix OperationsOnSeqNoDisabledIndicesIT#143892

Merged
fcofdez merged 3 commits intoelastic:mainfrom
fcofdez:fix-seq-no-disabled-test
Mar 10, 2026
Merged

Fix OperationsOnSeqNoDisabledIndicesIT#143892
fcofdez merged 3 commits intoelastic:mainfrom
fcofdez:fix-seq-no-disabled-test

Conversation

@fcofdez
Copy link
Copy Markdown
Contributor

@fcofdez fcofdez commented Mar 9, 2026

Ensure that there are enough data nodes for the test to run properly

Closes #143887

Ensure that there are enough data nodes for the test to run properly

Closes elastic#143887
@fcofdez fcofdez requested a review from inespot March 9, 2026 17:52
@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed Meta label for distributed team. v9.4.0 labels Mar 9, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Contributor

@inespot inespot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! One small question

import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;

@ESIntegTestCase.ClusterScope(scope = ESIntegTestCase.Scope.TEST, minNumDataNodes = 2)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be @ESIntegTestCase.ClusterScope(minNumDataNodes = 2) ? Or do we need a brand new cluster for each of testBulkWithMixedOperationsAcrossSeqNoDisabledAndEnabledIndices and testSingleUpdateOnSeqNoDisabledIndexIsRejected ? Considering indices are not shared between the two tests (and I believe ESIntegTestCase.beforeInternal() cleans up the cluster between tests when @SuiteScopeTestCase is not included)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch, I pushed 465e2c7

@fcofdez fcofdez merged commit 5a342fe into elastic:main Mar 10, 2026
36 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 10, 2026
…locations

* upstream/main: (126 commits)
  Update KnnIndexTester to use more settings from datasets (elastic#143869)
  fix: dynamic template vector array is overridden by automatic dense_vector mapping (elastic#143733)
  ES|QL: Don't reuse the same alias for _fork column (elastic#143909)
  Close and initialize clients after each node upgrade in logsdb rolling upgrade tests. (elastic#143823)
  ESQL: Added GroupedTopNOperator for LIMIT BY, compute only (elastic#143476)
  Handle views in ResolveIndexAction (elastic#143561)
  Improve reindex rethrottle API in stateless (elastic#143771)
  Use a copy of the SearchExecutionContext for each Percolator execution (elastic#142765)
  Log the stacktrace when we encounter a deprecation warning for `default_metric` (elastic#143929)
  ESQL: evaluate ReferenceAttributes to potentially FieldAttributes for full-text functions restriction (elastic#143893)
  Add ClusterStateSerializationStats Serializatation Tests (elastic#142703)
  Adds Coordination Diagnostics Tests (elastic#142709)
  Upgrade Elasticsearch to Apache Lucene 10.4 (elastic#141882)
  ESQL: Add configurable bracket-based multi-value support for CSV reader (elastic#143890)
  time series es819 binary dv use up to a 1mb block size (elastic#143049)
  Dynamically enable / disable plugins in correspondence to stateless mode. (elastic#142147)
  ES|QL: Implement first/last_over_time for tdigest (elastic#143832)
  Document CHANGE_POINT limitation (elastic#143877)
  Fix OperationsOnSeqNoDisabledIndicesIT (elastic#143892)
  [Test] Test that sequence numbers are not pruned with retention lease (elastic#143825)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed Meta label for distributed team. >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] OperationsOnSeqNoDisabledIndicesIT testBulkWithMixedOperationsAcrossSeqNoDisabledAndEnabledIndices failing

3 participants