time series es819 binary dv use up to a 1mb block size#143049
Merged
martijnvg merged 10 commits intoelastic:mainfrom Mar 10, 2026
Merged
time series es819 binary dv use up to a 1mb block size#143049martijnvg merged 10 commits intoelastic:mainfrom
martijnvg merged 10 commits intoelastic:mainfrom
Conversation
and no much higher value count threshold.
Member
Author
|
Buildkite benchmark this with clickbench-columnar-mode please |
Member
Author
|
Buildkite benchmark this with clickbench-columnar-mode please |
Member
Author
|
Buildkite benchmark this with elastic-logs-logsdb please |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
changed the title
parkertimmins
requested changes
Mar 9, 2026
| static final DocValuesFormat ES_819_3_TSDB_DOC_VALUES_FORMAT = new ES819Version3TSDBDocValuesFormat(); | ||
| static final DocValuesFormat ES_819_3_TSDB_DOC_VALUES_FORMAT_LARGE_NUMERIC_BLOCK = new ES819Version3TSDBDocValuesFormat(true); | ||
| static final DocValuesFormat ES_819_3_TSDB_DOC_VALUES_FORMAT_LARGE_BINARY_BLOCK = new ES819Version3TSDBDocValuesFormat(true, false); | ||
| static final DocValuesFormat ES_819_3_TSDB_DOC_VALUES_FORMAT_LARGE_NUMERIC_BLOCK = new ES819Version3TSDBDocValuesFormat(false, true); |
Contributor
There was a problem hiding this comment.
Looks like the booleans are flipped? Should be:
static final DocValuesFormat ES_819_3_TSDB_DOC_VALUES_FORMAT_LARGE_BINARY_BLOCK = new ES819Version3TSDBDocValuesFormat(false, true);
static final DocValuesFormat ES_819_3_TSDB_DOC_VALUES_FORMAT_LARGE_NUMERIC_BLOCK = new ES819Version3TSDBDocValuesFormat(true, false);
Member
Author
|
Buildkite benchmark this with clickbench-columnar-mode please |
Member
Author
|
Running another benchmark just to make sure that, larger binary blocks are being used. |
Collaborator
💚 Build Succeeded
This build ran two clickbench-columnar-mode benchmarks to evaluate performance impact of this PR. History
|
martijnvg
added a commit
to martijnvg/rally-tracks
that referenced
this pull request
Mar 10, 2026
By setting to `index.use_time_series_doc_values_format_large_binary_block_size` to `true`. This was recently added via elastic/elasticsearch#143049.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 10, 2026
…locations * upstream/main: (126 commits) Update KnnIndexTester to use more settings from datasets (elastic#143869) fix: dynamic template vector array is overridden by automatic dense_vector mapping (elastic#143733) ES|QL: Don't reuse the same alias for _fork column (elastic#143909) Close and initialize clients after each node upgrade in logsdb rolling upgrade tests. (elastic#143823) ESQL: Added GroupedTopNOperator for LIMIT BY, compute only (elastic#143476) Handle views in ResolveIndexAction (elastic#143561) Improve reindex rethrottle API in stateless (elastic#143771) Use a copy of the SearchExecutionContext for each Percolator execution (elastic#142765) Log the stacktrace when we encounter a deprecation warning for `default_metric` (elastic#143929) ESQL: evaluate ReferenceAttributes to potentially FieldAttributes for full-text functions restriction (elastic#143893) Add ClusterStateSerializationStats Serializatation Tests (elastic#142703) Adds Coordination Diagnostics Tests (elastic#142709) Upgrade Elasticsearch to Apache Lucene 10.4 (elastic#141882) ESQL: Add configurable bracket-based multi-value support for CSV reader (elastic#143890) time series es819 binary dv use up to a 1mb block size (elastic#143049) Dynamically enable / disable plugins in correspondence to stateless mode. (elastic#142147) ES|QL: Implement first/last_over_time for tdigest (elastic#143832) Document CHANGE_POINT limitation (elastic#143877) Fix OperationsOnSeqNoDisabledIndicesIT (elastic#143892) [Test] Test that sequence numbers are not pruned with retention lease (elastic#143825) ...
martijnvg
added a commit
to elastic/rally-tracks
that referenced
this pull request
Mar 11, 2026
By setting to index.use_time_series_doc_values_format_large_binary_block_size to true in elastic/logs and elastic/security benchmarks. This was recently added via elastic/elasticsearch#143049.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change time series doc values format to increase the block size threshold for binary doc values from 128kb to 1mb. The value count threshold is increased from 1024 to 32768. This change is gated behind and index setting and the index setting is gated behind a feature flag, which allows to experiment with this change in benchmarks.
Adhoc benchmark runs against clickbench rally track shows a good decrease (16.18GB to 15.20GB) in disk usage, somewhat higher indexing through, while query latency stays within noise boundaries: https://esbench-metrics.kb.us-east-2.aws.elastic-cloud.com:9243/app/r/s/lApCT