Merged
Conversation
In elastic#142816 we moved memory tracking into `Tracking*DocValues` classes for all block loaders except one. This gets the last one.
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
idegtiarenko
approved these changes
Feb 24, 2026
Member
Author
|
So! The tests discovered a fun thing. The |
jordan-powers
added a commit
to jordan-powers/elasticsearch
that referenced
this pull request
Feb 28, 2026
tballison
pushed a commit
to tballison/elasticsearch
that referenced
this pull request
Mar 3, 2026
In elastic#141926 I deprecated the `AllReader` because we no longer need to make a `BlockLoader` work both row-by-row and column-at-a-time. Now it's fine for a `BlockLoader` to work in either mode. And `AllReader` was the tool that we used to support working both ways. So it can go! This removes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #141926 I deprecated the
AllReaderbecause we no longer need to make aBlockLoaderwork both row-by-row and column-at-a-time. Now it's fine for aBlockLoaderto work in either mode. AndAllReaderwas the tool that we used to support working both ways. So it can go! This removes it.