ESQL: Consolidate doc values memory tracking#142816
Merged
nik9000 merged 7 commits intoelastic:mainfrom Feb 23, 2026
Merged
Conversation
Member
Author
|
This should be easier to read. |
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
Member
Author
|
@dnhatn, this was my idea for making this more readable. There's a lot of |
Member
Author
|
#142807 removes most of the remaining references to the |
martijnvg
approved these changes
Feb 23, 2026
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM, looks cleaner to me 👍
| * Wraps a {@link BinaryDocValues}, reserving some space in a {@link CircuitBreaker} | ||
| * while it is live. | ||
| */ | ||
| public class TrackingBinaryDocValues implements Releasable { |
Member
There was a problem hiding this comment.
Can this also be a record? And would the same apply for the others tracking classes below?
…to esql_rework_loader_tracking
dnhatn
approved these changes
Feb 23, 2026
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the follow-up!
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Feb 23, 2026
In elastic#142816 we moved memory tracking into `Tracking*DocValues` classes for all block loaders except one. This gets the last one.
jdconrad
pushed a commit
to jdconrad/elasticsearch
that referenced
this pull request
Feb 24, 2026
Moves the memory tracking for doc values loading in `BlockLoader.Reader` into `Tracking*DocValues` classes and a couple of utilities to atomically create them.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Feb 24, 2026
…on-sliced-reindex * upstream/main: Update docs for v9.3.1 release (elastic#142887) Update docs for v9.2.6 release (elastic#142888) Improves visibility of vector index options and inference configuration (elastic#141653) Disable CAE in microsoft-graph-authz plugin (elastic#142848) Small improvements to `GetSnapshotsIT#testAllFeatures` (elastic#142825) Fix IndexSettingsTests synthetic ID tests (elastic#142654) [Test] Unmute tests of SnapshotShutdownIT (elastic#142921) Fixing metrics_info.json kibana definition file name (elastic#142813) [Packaging] Disable glibc 2.43 malloc huge pages in Wolfi images (elastic#142894) Mute org.elasticsearch.xpack.searchablesnapshots.SearchableSnapshotsTSDBSyntheticIdIntegTests testSearchableSnapshot elastic#142918 Add shard heap usage to ClusterInfo (elastic#139557) ESQL: Load script fields row-by-row (elastic#142807) ESQL: Consolidate doc values memory tracking (elastic#142816) ES-14124 Create Index Count Limit User documentation Page (elastic#142570) Add a es819 codec test to verify tryRead returns null if may contain duplicates (elastic#142409) Support arithmetic operations for dense_vectors: scalar version (elastic#141060) [Transform] Allow project_routing (elastic#142421) Refactor query rewrite async actions for knn and sparse_vector queries (elastic#142889) Do not mark bulk indexing requests as retried after primary relocations (elastic#142157)
sidosera
pushed a commit
to sidosera/elasticsearch
that referenced
this pull request
Feb 24, 2026
Moves the memory tracking for doc values loading in `BlockLoader.Reader` into `Tracking*DocValues` classes and a couple of utilities to atomically create them.
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the memory tracking for doc values loading in
BlockLoader.ReaderintoTracking*DocValuesclasses and a couple of utilities to atomically create them.